Conversations+

Notice: Undefined index: tasklist_type in /var/www/clients/client5/web39/bugs/includes/class.tpl.php(128) : eval()'d code on line 85 Notice: Undefined index: tasklist_type in /var/www/clients/client5/web39/bugs/includes/class.tpl.php(128) : eval()'d code on line 90
  • Status Closed
  • Percent Complete
    100%
  • Task Type Bug Report
  • Category App → User Interface
  • Assigned To Tristan Zur (tzur)
  • Operating System All
  • Severity Medium
  • Priority Normal
  • Reported Version Conversations+ 0.0.7
  • Due in Version Undecided
  • Due Date Undecided
  • Votes 0
  • Private No
Attached to Project: Conversations+
Opened by Sebastian Luksch (lookshe) - 2016-02-09
Last edited by Sebastian Luksch (lookshe) - 2016-03-28

FS#135 - disable notification for received/downloaded images when link is received through mam or carbons

When an image link is received via mam, a notification is pushed. This does not happen for "normal" messages received via mam. Behaviour should be normalised.

Seems to occur again.

This task does not depend on any other tasks.

Closed by  Sebastian Luksch (lookshe)
Monday, 28 March 2016, 12:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  Was already fixed. Notification was only an old stream.
Tristan Zur (tzur)
Tuesday, 09 February 2016, 20:46 GMT
Possible root cause:
Normal messages are notified if not message.isRead() (ref. http://git.fucktheforce.de/conversations-plus/tree/src/main/java/de/thedevstack/conversationsplus/parser/MessageParser.java#n379)
In case of an auto downloaded file this condition is missing. (ref. http://git.fucktheforce.de/conversations-plus/tree/src/main/java/de/thedevstack/conversationsplus/http/HttpDownloadConnection.java#n112)

Solution is in that case to add the condition "!message.isRead()" in boolean NotificationService.notify()

Loading...